Auto parse number fix on unsafe numbers#8
Merged
Conversation
…loss for large integers
…loss for large integers
snuysal
approved these changes
Mar 26, 2026
snuysal
approved these changes
Mar 26, 2026
snuysal
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new option,
preserveUnsafeIntegersAsString, to the CSV parsing library. When enabled alongsideautoParseNumbers, this option ensures that integer strings outside JavaScript's safe integer range are preserved as strings, preventing precision loss. The default behavior remains unchanged, and the new option is opt-in. The update includes changes to the core parsing logic, documentation, and adds comprehensive tests to cover the new functionality.Feature: Preserve Unsafe Integers as Strings
preserveUnsafeIntegersAsStringoption toCsvParserOptionsand updated the parsing logic in bothCsvStreamParserandNestedJsonConverterto use this option when parsing numbers, preserving unsafe integers as strings to avoid precision loss. [1] [2] [3] [4] [5] [6] [7] [8]Documentation Updates
README.mdto document the newpreserveUnsafeIntegersAsStringoption, including usage examples and notes about JavaScript number precision. [1] [2]Testing
csv-stream-parser.test.tsandedge-cases.test.tsto verify correct behavior when the option is enabled, default behavior remains unchanged, and safe integers are still parsed as numbers. [1] [2]Release Notes